Subtitles background opacity #4423
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/src/main/java/org/jellyfin/androidtv/preference/UserPreferences.kt
Outdated
Show resolved
Hide resolved
OwOchle
changed the title
OwOchle
changed the title
nielsvanvelzen
requested changes
Feb 19, 2025
| @@ -44,6 +44,7 @@ | |||
| import org.jellyfin.androidtv.data.compat.StreamInfo; | |||
| import org.jellyfin.androidtv.preference.UserPreferences; | |||
| import org.jellyfin.androidtv.preference.constant.ZoomMode; | |||
| import org.jellyfin.androidtv.util.ColorUtilsKt; | |||
There was a problem hiding this comment.
Seems like an unused import?
| @@ -1,5 +1,6 @@ | |||
| package org.jellyfin.androidtv.ui.preference.screen | |||
|
|
|||
| import okhttp3.internal.toHexString | |||
There was a problem hiding this comment.
You shouldn't use an internal function from a sub-dependency
There was a problem hiding this comment.
Oh sorry, I thought it was the kotlin stdlib function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Option to configure subtitles background opacity and function to apply it onto existing colors.